Skip to content

Add lightbug_http v0.1.19 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Add lightbug_http v0.1.19 #37

wants to merge 40 commits into from

Conversation

saviorand
Copy link

Checklist

  • License file is packaged (see here for an example).
  • Set the build number to 0 (for new packages, or if the version changed)
  • Bumped the build number (if the version is unchanged)

@saviorand
Copy link
Author

Since we have many different test files I've tried adding tests from source, not from the recipe in recipe.yaml. Does thta work? Or how can I fix?

@saviorand
Copy link
Author

Also 0.1.6 is only going out later today / early tomorrow, thought I'd submit this in advance. Will let y'all know here when it's ready 🙏

@saviorand
Copy link
Author

Done, 0.1.6 is out!

@saviorand
Copy link
Author

Actually, just shipped a hotfix at 0.1.7. Updated the version in the recipe.
@carolinefrasca @zbowling let me know if this approach with including the tests from source will work or if I have to include all our tests as one file

@carolinefrasca
Copy link
Collaborator

@saviorand Apologies for the delayed response! For now, if you don't mind including the tests in this PR too, that would be great. We're asking folks to include the tests in this repo so that we can automatically run the tests after your package builds. I realize this is a bit of a pain though, and I'm looking into alternative solutions for the long run.

@saviorand
Copy link
Author

@carolinefrasca no problem at all, but I'm wondering if I can include multiple test files? Or does it all have to be in one big file

@carolinefrasca
Copy link
Collaborator

@saviorand You can definitely include multiple test files! Check out mojmelo for an example of how to structure the recipe file – the test files were just included in a /tests folder.

@saviorand saviorand changed the title Add lightbug_http v0.1.6 Add lightbug_http v0.1.8 Jan 8, 2025
@saviorand
Copy link
Author

@carolinefrasca done! let me know if there's anything else i should tweak

@carolinefrasca
Copy link
Collaborator

Hi @saviorand, it looks like the linter is finding trailing whitespace in your README – however, we're actually dropping the requirement to include a README in the PR, as long as your package's repo has a README (and yours does) – so the easiest way to resolve this error is probably to just delete the README from this PR, if that's okay with you?

@saviorand
Copy link
Author

@carolinefrasca yes, that works, thanks!

@carolinefrasca
Copy link
Collaborator

Perfect – are you able to remove the file from the PR?

@saviorand
Copy link
Author

@carolinefrasca done!

carolinefrasca
carolinefrasca previously approved these changes Jan 14, 2025
@carolinefrasca
Copy link
Collaborator

Thank you @saviorand! Unfortunately we're still seeing an error – I believe the build script just needs to be updated to:
mojo package lightbug_http -o ${{ PREFIX }}/lib/mojo/lightbug_http.mojopkg in recipe.yaml

@saviorand
Copy link
Author

@carolinefrasca done, could you trigger the pipeline again?

@carolinefrasca
Copy link
Collaborator

A quick update for everyone with open PRs that will hopefully make this process a bit easier: it's actually not necessary to include your test file(s) in the PR if you'd like to keep them in your source repo instead, as long as you include the test invocation and SHA/ID for your GitHub in the recipe file (here's an example with @TilliFe's Endia). Please let me know if you have any questions!

@saviorand
Copy link
Author

@carolinefrasca not sure what's the difference between this recipe in Endia and the current version in this PR?

@saviorand
Copy link
Author

@carolinefrasca just fixed that! Thanks for flagging

@saviorand saviorand changed the title Add lightbug_http v0.1.11 Add lightbug_http v0.1.13 Feb 23, 2025
@saviorand
Copy link
Author

@carolinefrasca could I ask you to trigger the pipeline again? just noticed the recipe had an older MAX version set

@saviorand saviorand changed the title Add lightbug_http v0.1.13 Add lightbug_http v0.1.15 Mar 2, 2025
@saviorand
Copy link
Author

Just bumped the version again! Looks like the recipe was wrong on the main branch, maybe that was causing the issue. 🤞

@saviorand saviorand changed the title Add lightbug_http v0.1.15 Add lightbug_http v0.1.17 Apr 10, 2025
@saviorand
Copy link
Author

@carolinefrasca bumped the version again to the latest release, if this still doesn't fix it I'm going to remove small_time as a mojoproject.toml dependency, then the build should pass for sure

@saviorand
Copy link
Author

@carolinefrasca could you please trigger the ci here? just wanted to check if it fails still, then I'll just include small_time in lightbug's repo directly for now, not over magic, since we can't seem to figure out this weird dependency issue

@saviorand saviorand changed the title Add lightbug_http v0.1.17 Add lightbug_http v0.1.19 Apr 22, 2025
@saviorand
Copy link
Author

@carolinefrasca okay, now it should definitely work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants