fix: use LSP-compliant dynamic file watcher registration#75
Open
Swahjak wants to merge 1 commit intomoetelo:masterfrom
Open
fix: use LSP-compliant dynamic file watcher registration#75Swahjak wants to merge 1 commit intomoetelo:masterfrom
Swahjak wants to merge 1 commit intomoetelo:masterfrom
Conversation
Move file watching from client-side (VSCode-specific) to server-side using the LSP standard `client/registerCapability` request. This makes the extension compatible with other LSP-compliant editors (Neovim, Sublime, Emacs, etc.) by: - Removing client-side FileSystemWatcher from extension.ts - Adding dynamic registration for didChangeWatchedFiles in onInitialized - Handling file changes via connection.onDidChangeWatchedFiles - Adding remove() and refresh() methods to DocumentCache Fixes moetelo#54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client/registerCapabilityrequestFileSystemWatcherfromextension.tsdidChangeWatchedFilesinonInitializedconnection.onDidChangeWatchedFilesremove()andrefresh()methods toDocumentCacheBenefits
Test plan
Fixes #54