-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reference local path for inputs to run the GCBM example #84
Conversation
@HarshCasper @aornugent , currently this works for the inputs, should this be extended to the output folder too? |
Hey @Namyalg - Because FLINT.cloud can be run both locally and remotely, I think it might be better to introduce a second endpoint to change the path in the scenario where input files are mounted and available locally. This way there would a user would have two options:
Are you able to change this to leave the |
Yes, I think that can be achieved
I was thinking, eliminating the need to POST files to the endpoint will make it easier and reduce the chance of errors as there might be a lot of files to upload (specifically talking about Postman as it does not support folder uploads) I wanted to understand more about scenario 2, when there are no input files available, does this mean the files are present on the cloud and only their path is accessed ? |
What if we had three endpoints:
There should be a sensible default for 1. so that users only need to call this endpoint if they need to change the path. Note: here 'local' refers to a path that can be accessed by the app - if the app is running in a Docker container this might be a mounted volume on the host or a temporary file system that is deleted when the container is stopped.
In this scenario, a user might not have access to the volumes of a FLINTcloud container (i.e. it's running on a remote server). When they want to change the input files, they need some way to send them to the server for the container to access. This is the intended use case of the |
In my understanding, |
Pull Request Template
Description
This PR enables referencing a local path to supply inputs to the GCBM example. A volume is mounted onto the container, which is referenced in
app.py
. This eliminates the need toPOST
files at the/gcbm/upload
endpoint.The documentation has been updated accordingly.
Fixes #83
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Testing has been performed by building the docker image and running the API endpoints
Checklist: