Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue with
TestUserAgent
where several assertion methods, such as.jsonIs()
, did not work when using the nativenode:assert/strict
module, specifically due to missing assertion methods likeassert.same()
.Fix
node:assert/strict
, such as replacingassert.same()
withassert.deepStrictEqual()
for deep equality checks.tap
andnode:assert/strict
modes in theTestUserAgent
to provide flexibility in testing.Changes
_assert
methods toTestUserAgent
to support the required assertions:assert.equal
→assert.strictEqual
assert.not
→assert.notStrictEqual
assert.match
→assert.match
assert.notMatch
→assert.doesNotMatch
assert.ok
→assert.ok
assert.notOk
→ custom implementation for negatedassert.ok
assert.same
→assert.deepStrictEqual
tap
andnode:assert/strict
modes.Caveat
This fix maps
node:assert/strict
methods to theirtap
counterparts. This could give the impression that we are prioritizing thetap
API over the nativenode:assert
API.If preferred, we can consider making
node:assert/strict
the primary module for assertions inTestUserAgent
and refactor the code accordingly.