Change MojoModels from type to interface

[dmanto]

Description

This PR updates the MojoModels definition from a type to an interface to enable declaration merging. This change allows developers to extend MojoModels in their applications, similar to how MojoContext can be extended.

Declaration merging is a key TypeScript feature that enhances extensibility, making it easier for developers to define and use typed models within their apps.

Changes Made

1. Updated src/types.ts file:

Replaced

type MojoModels = Record<string, any>;

with:

export interface MojoModels {
  [key: string]: any;
}

2. Modified an Existing Test File:
   Added a declaration merging example in the existing test file ./test/support/ts/full-app/src/index.ts. Here's how the declare module portion looks:

declare module '../../../../../lib/core.js' {
  interface MojoModels {
    bar: Bar;
  }
}

This demonstrates how developers can extend MojoModels and assign strongly typed properties like bar. It effectively verifies that the updated MojoModels supports declaration merging, as reverting to a type causes the test file to fail during the build process.

Benefits

Enables developers to extend MojoModels via declaration merging, improving type safety and flexibility.
Provides an example in the test file to illustrate usage, making it easier for others to adopt this pattern.

Considerations

1. The modification to the test file is not a "formal" TypeScript test but serves as an effective demonstration of declaration merging in action. This change can be revised or removed based on feedback.
2. ESLint's @typescript-eslint/consistent-indexed-object-style rule was disabled inline for MojoModels since it enforces Record over interface.

[kraih]

Thanks, looks like a very reasonable change. Wonder if we should just disable the eslint rule though, manual disabling looks ugly, and i'm not sure how useful it actually is for us. 🤔

[dmanto]

Just checked that adding '@typescript-eslint/consistent-indexed-object-style': 'off' to the rules array in eslint.config.js disables the rule globally, and everything looks perfect after that. The rule doesn’t seem particularly useful outside of very specific cases, and in this context, where interface is required for declaration merging, it feels counterproductive.

Let me know if you'd like me to include this change as part of the PR. Also, in that case, let me know if you’d like me to squash the two commits.

[kraih]

Yes, please include the change and squash.

[dmanto]

Just checking in on this—let me know if there's anything else you'd like me to adjust.

[kraih]

Sorry, i just forgot.