Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clipping of page size selector when viewport is tall #97

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix: clipping of page size selector when viewport is tall #97

merged 1 commit into from
Feb 19, 2024

Conversation

ckouder
Copy link
Contributor

@ckouder ckouder commented Feb 16, 2024 •
edited by bodom0015
Loading

Fixes #85

originally on results component, the paginator will be clipped if the viewport is tall
image
now:
image

@ckouder ckouder linked an issue Feb 16, 2024 that may be closed by this pull request
fix clipping of page size selector when viewport is tall (solution: force to open up) #85
Closed
bodom0015
bodom0015 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@bodom0015 bodom0015 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 works as advertised

Well done, @ckouder! 🎉

@ckouder ckouder merged commit 7032e94 into main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodom0015 bodom0015 bodom0015 approved these changes

@matthewberry matthewberry Awaiting requested review from matthewberry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix clipping of page size selector when viewport is tall (solution: force to open up)
2 participants
@ckouder @bodom0015