Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: marvinjs-modal-layout #98

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

ckouder
Copy link
Contributor

@ckouder ckouder commented Feb 16, 2024

Fixes #77

originally there will be scroll bar on top and side of the toolbar when screen size is small. this is caused by the resize of popup component. (notice the triangles on top of the toolbar and bottom left of the side-toolbar)
image

now you should not see any of those unless you are on a very small screen
image

Copy link
Member

@bodom0015 bodom0015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nicely done! 🎊

@ckouder ckouder merged commit d58e9f8 into main Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adjust MarvinJS modal layout
2 participants