Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow sorting by Number of Atoms #99

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Feb 19, 2024

Problem

We would like to display/sort by the number of atoms in each molecule

Fixes #76

Relates to moleculemaker/mmli-backend#30

Approach

  • Added new option to sort by "Number of Atoms" - this is now returned from the API as atom_count

How to Test

This is currently deployed on chemscraper-frontend-staging

  1. Navigate to https://chemscraper.frontend.staging.mmli1.ncsa.illinois.edu/results/02b0034a-4335-4823-8d5d-915b54173995
  2. Click on the Sort options at the top-right of the table (default: "Location in PDF")
    • You should see a new option here for "Number of Atoms"
  3. Choose to sort by "Number of Atoms"
    • You should see the table reorder itself to sort by atom_count
  4. Click the blue button on the popover to change whether to sort by ascending or descending

@bodom0015 bodom0015 merged commit 435f935 into main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable sort by number of atoms
3 participants