-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ReactionMiner backend job, skip duplicate emails, fix casing for novoStoic in emails #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mments to config.yml and values.yaml about this (including format)
…ubejob_service.cretae_job
bodom0015
commented
Jan 24, 2025
tested with b59e86d9e23148af9d596e1433ee1787 everything looks good! Thank you Sara! 🎉 |
ckouder
reviewed
Jan 24, 2025
ckouder
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Sara!
Thank you, @ckouder! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need a way to run ReactionMiner using mmli-backend
Approach
pvc-explorer
pod to mount full mmli1 NFS share (for debugging)novoStoic
when sending email notificationsfile_content
as string inMinIOService.upload_file()
How to Test
Currently deployed to
mmli-backend-staging
reactionminer
bucketjob_id
blank and it will create + return a newjob_id
for you to use - save thisjob_id
for laterjob_type=reactionminer
- make sure to use the samejob_id
where you uploaded the PDF filestaging
namespacejob_type=reactionminer
and the samejob_id
where you uploaded the PDF filecompleted
, check the output files usingbucket_name=reactionminer
and the samejob_id