fix(exec): honor explicit null node selection - #1248
Merged
Conversation
Signed-off-by: mikemikimike <13286568797@163.com>
Contributor
Greptile SummaryThe PR now distinguishes an explicitly null
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/tools/src/exec.rs | Correctly exposes null in the node schema and treats explicit null as a local-execution override without changing omitted-node behavior. |
| crates/tools/src/exec/tests.rs | Adds focused regression tests covering explicit-null local routing and the corresponding schema contract. |
Reviews (2): Last reviewed commit: "fix(exec): allow null node in tool schem..." | Re-trigger Greptile
Author
|
fixed-in-7bdc19e |
Collaborator
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node: nullas a request to use the local execution pathnodeis omittedRoot cause
ExecToolconverted the optionalnodevalue to a string and then fell back to the configured or provider default whenever that conversion returnedNone. This made an explicit JSON null indistinguishable from an omitted field, so a tool call intended to return to the local sandbox continued to execute on the selected SSH node.Validation
crates/tools/src/exec.rsgit diff --checkCloses #1246.