Skip to content

chore: no use cargo in sqlx-prepare - #299

Merged
mightyiam merged 1 commit into
mainfrom
no-cargo-in-sqlx-prepare
Sep 2, 2026
Merged

chore: no use cargo in sqlx-prepare#299
mightyiam merged 1 commit into
mainfrom
no-cargo-in-sqlx-prepare

Conversation

@mightyiam

Copy link
Copy Markdown
Member

No description provided.

@mightyiam

Copy link
Copy Markdown
Member Author

I'm pretty sure that eventually, sqlx is called anyway. So this is more direct.

@mightyiam
mightyiam requested a review from jfly September 1, 2026 03:38

@jfly jfly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, I don't really understand what's changing here, but if it works, it works!

@mightyiam

Copy link
Copy Markdown
Member Author

Cargo has this arguably helpful feature, where if it's called with a sub-command it doesn't have, it will try to call cargo-<subcommand> if such a thing is in the path. And I suppose the sqlx package in nixpkgs provides both cargo-sqlx and sqlx. So, this is more direct.

@mightyiam
mightyiam force-pushed the no-cargo-in-sqlx-prepare branch from 5a43af0 to 037e06b Compare September 1, 2026 04:27
@mightyiam
mightyiam enabled auto-merge September 1, 2026 04:28
@mightyiam
mightyiam force-pushed the no-cargo-in-sqlx-prepare branch from 037e06b to ae8c3e7 Compare September 2, 2026 14:25
@mightyiam
mightyiam merged commit a4e452c into main Sep 2, 2026
3 checks passed
@mightyiam
mightyiam deleted the no-cargo-in-sqlx-prepare branch September 2, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants