Skip to content

Commit

Permalink
fix(shared): bad naming of MapLeaderboardGetRunQuery
Browse files Browse the repository at this point in the history
  • Loading branch information
tsa96 committed Dec 29, 2023
1 parent 7c3ea67 commit ea17e1f
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions apps/backend/src/app/modules/maps/maps.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ import {
CreateMapWithFilesDto,
MapZonesDto,
LeaderboardRunDto,
MapLeaderboardGetRunQuery,
MapLeaderboardGetRunQueryDto,
MinimalLeaderboardRunDto
} from '@momentum/backend/dto';
import { LoggedInUser, Roles } from '@momentum/backend/decorators';
Expand Down Expand Up @@ -670,7 +670,7 @@ export class MapsController {
getLeaderboardRun(
@Param('mapID', ParseIntSafePipe) mapID: number,
@LoggedInUser('id') userID: number,
@Query() query?: MapLeaderboardGetRunQuery
@Query() query?: MapLeaderboardGetRunQueryDto
): Promise<LeaderboardRunDto> {
return this.runsService.getRun(mapID, query, userID);
}
Expand Down
4 changes: 2 additions & 2 deletions apps/backend/src/app/modules/runs/leaderboard-runs.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { SteamService } from '../steam/steam.service';
import {
DtoFactory,
MapLeaderboardGetQueryDto,
MapLeaderboardGetRunQuery,
MapLeaderboardGetRunQueryDto,
PagedResponseDto,
LeaderboardRunDto,
MinimalLeaderboardRunDto
Expand Down Expand Up @@ -144,7 +144,7 @@ export class LeaderboardRunsService {

async getRun(
mapID: number,
query: MapLeaderboardGetRunQuery,
query: MapLeaderboardGetRunQueryDto,
loggedInUserID: number
): Promise<LeaderboardRunDto> {
const where: Prisma.LeaderboardRunWhereInput = {
Expand Down
6 changes: 3 additions & 3 deletions libs/backend/dto/src/queries/map-queries.dto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
MapLeaderboardGetQuery,
MapRunsGetExpand,
MapRunsGetFilter,
MapLeaderboardGetRun
MapLeaderboardGetRunQuery
} from '@momentum/constants';
import {
MapCreditsGetQuery,
Expand Down Expand Up @@ -272,9 +272,9 @@ export class MapLeaderboardGetQueryDto
readonly orderByDate?: boolean;
}

export class MapLeaderboardGetRunQuery
export class MapLeaderboardGetRunQueryDto
extends QueryDto
implements MapLeaderboardGetRun
implements MapLeaderboardGetRunQuery
{
@EnumQueryProperty(Gamemode, { required: true })
gamemode: Gamemode;
Expand Down
2 changes: 1 addition & 1 deletion libs/constants/src/types/queries/map-queries.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export type MapLeaderboardGetQuery = PagedQuery & {
orderByDate?: boolean;
};

export type MapLeaderboardGetRun = PagedQuery & {
export type MapLeaderboardGetRunQuery = PagedQuery & {
gamemode: Gamemode;
trackType?: TrackType; // Default 0
trackNum?: number; // Default 0
Expand Down
2 changes: 1 addition & 1 deletion libs/frontend/data/src/lib/leaderboards.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { Observable } from 'rxjs';
import {
LeaderboardRun,
MapLeaderboardGetQuery,
MapLeaderboardGetRunQuery,
PagedResponse
} from '@momentum/constants';
import { HttpService } from './http.service';
import { MapLeaderboardGetRunQuery } from '@momentum/backend/dto';

@Injectable({ providedIn: 'root' })
export class LeaderboardsService {
Expand Down

0 comments on commit ea17e1f

Please sign in to comment.