Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunked Map Uploading for Maps larger than 100MB #318

Closed
Gocnak opened this issue Apr 29, 2019 · 8 comments · Fixed by #964
Closed

Chunked Map Uploading for Maps larger than 100MB #318

Gocnak opened this issue Apr 29, 2019 · 8 comments · Fixed by #964
Assignees
Labels
For: Frontend This is something to do for the front end (client folder) of the website. Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. Size: Small Something that may take a day at most to do. Type: Enhancement Something that builds on top of what already exists

Comments

@Gocnak
Copy link
Member

Gocnak commented Apr 29, 2019

Our file uploading process is currently just a single POST request to the backend. It'd be great to get resume-able uploads with multi part chunking it, especially when we move to cloud storage.

The frontend should update visually to respect this!

@Gocnak Gocnak added the Type: Enhancement Something that builds on top of what already exists label Apr 29, 2019
@Gocnak Gocnak added this to the 0.9.0 milestone Apr 29, 2019
@Gocnak Gocnak added the Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. label May 9, 2019
@Hona Hona added For: Frontend This is something to do for the front end (client folder) of the website. Size: Small Something that may take a day at most to do. labels Nov 1, 2020
@KJelles
Copy link
Contributor

KJelles commented Dec 12, 2021

I looked into this @Gocnak but it feels like Uppy is a bit wack with Angular, their latest package isn't even bundled correctly :) Might need to just improve on the file-upload component visually instead

@Gocnak Gocnak changed the title Consider using Uppy file uploader Update Uploading Logic + Look Dec 12, 2021
@Gocnak
Copy link
Member Author

Gocnak commented Dec 12, 2021

Yep that's fair! I'll rename the issue to better fit then.

@tsa96 tsa96 removed this from the 0.9.0 milestone Sep 28, 2023
@tsa96 tsa96 self-assigned this Sep 28, 2023
@tsa96
Copy link
Member

tsa96 commented Dec 29, 2023

Do we really this? Most modern internet should be able to handle a single POST request of ~100mb perfectly fine, and 0.10.0 deploy shouldn't have an issue with files > 100mb, even though it still streams through the backend. As me and Nick discussed recently, if our backend instances are started to use too much bandwidth and we need to do fancier upload stuff we can, but until we actually run into that problem (with the 0.10.0 deploy), we're fighting with a (often extremely complex) problem before it's actually affected us.

@Gocnak if you agree, then #869 closes this.

@Gocnak
Copy link
Member Author

Gocnak commented Jan 6, 2024

Note that if we're protecting our backend via Cloudflare, we will need to have multipart uploading to get any file > 100 MB uploaded, unless we use presigned URLs.

@tsa96
Copy link
Member

tsa96 commented Jan 6, 2024

Sorry, what Cloudflare system requires this? Is there really no way to configure this?

@tsa96 tsa96 changed the title Update Uploading Logic + Look Chunked Map Uploading for Maps larger than 100MB Feb 14, 2024
@tsa96 tsa96 changed the title Chunked Map Uploading for Maps larger than 100MB Update Uploading Logic + Look Feb 14, 2024
@tsa96
Copy link
Member

tsa96 commented Feb 14, 2024

We discussed this a few weeks ago, our free Cloudflare DDoS stuff limits to maximum of 100MB.

Chunking with current system is really annoying given our only state atm is in Postgres.

Since we don't do anything with BSPs (currently) on the backend the easiest approach is probably presigned URLs. But this is definitely low priority, maps should really try to stay under 100MB. Not sure it's completely necessary for 0.10.0.

@tsa96 tsa96 changed the title Update Uploading Logic + Look Chunked Map Uploading for Maps larger than 100MB Feb 15, 2024
@tsa96 tsa96 moved this to Todo in Map Submission May 27, 2024
@tsa96
Copy link
Member

tsa96 commented Jun 16, 2024

Okay we can chunking and use disk but needs a spec, don't have time now, ping me if interested in doing this.
Will need to implement some separate disk-based io stuff since not doing anything currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For: Frontend This is something to do for the front end (client folder) of the website. Priority: Low Something not very essential to the release, can be done in free time and bumped back if needed. Size: Small Something that may take a day at most to do. Type: Enhancement Something that builds on top of what already exists
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants