Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-signed urls for map submission #964

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Pre-signed urls for map submission #964

merged 4 commits into from
Jun 26, 2024

Conversation

GordiNoki
Copy link
Member

@GordiNoki GordiNoki commented Jun 26, 2024

Closes #705
Closes #318

When uploading BSP for map submission s3 pre-signed urls will be used now.

Checks

  • I have included/updated tests where applicable (see Testing)
  • I have ran nx run db:create-migration and committed the migration if I've made DB schema changes
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits

@GordiNoki GordiNoki requested a review from tsa96 June 26, 2024 14:07
@GordiNoki GordiNoki force-pushed the feat/pre-signed-urls branch from 8f11596 to b2fa0e3 Compare June 26, 2024 14:19
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work! Though, the mapSubmissionVersion endpoint has essentially the behavior as this and also needs changing.

@GordiNoki
Copy link
Member Author

Though, the mapSubmissionVersion endpoint has essentially the behavior as this and also needs changing.

I did do the same behavior for POST /maps/:mapID

@GordiNoki GordiNoki force-pushed the feat/pre-signed-urls branch 2 times, most recently from 688ffbb to fb0bcfb Compare June 26, 2024 15:23
@GordiNoki
Copy link
Member Author

I do really need to figure out why eslint doesn't work in my ide...

@GordiNoki GordiNoki requested a review from tsa96 June 26, 2024 15:26
@tsa96
Copy link
Member

tsa96 commented Jun 26, 2024

Though, the mapSubmissionVersion endpoint has essentially the behavior as this and also needs changing.

I did do the same behavior for POST /maps/:mapID

Oh right, I'm an idiot. Aren't you missing frontend stuff for it though?

@GordiNoki GordiNoki force-pushed the feat/pre-signed-urls branch from fb0bcfb to ba76987 Compare June 26, 2024 15:47
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay LGTM, can merge once CI passes

@GordiNoki GordiNoki merged commit 634d713 into main Jun 26, 2024
5 checks passed
@GordiNoki GordiNoki deleted the feat/pre-signed-urls branch June 26, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 Pre-signed URLs for upload endpoints Chunked Map Uploading for Maps larger than 100MB
2 participants