-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-signed urls for map submission #964
Conversation
8f11596
to
b2fa0e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work! Though, the mapSubmissionVersion
endpoint has essentially the behavior as this and also needs changing.
I did do the same behavior for POST /maps/:mapID |
688ffbb
to
fb0bcfb
Compare
I do really need to figure out why eslint doesn't work in my ide... |
Oh right, I'm an idiot. Aren't you missing frontend stuff for it though? |
fb0bcfb
to
ba76987
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay LGTM, can merge once CI passes
Closes #705
Closes #318
When uploading BSP for map submission s3 pre-signed urls will be used now.
Checks
nx run db:create-migration
and committed the migration if I've made DB schema changesfeat: Add foo
,chore: Update bar
, etc...fixup
ed into my original commits