Constant value xp systems #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
added
Size: Small
tsa96
force-pushed
the
refactor/constant-xp-systems
branch
5 times, most recently
from
e4859ac to
b518062
Compare
tsa96
force-pushed
the
refactor/constant-xp-systems
branch
4 times, most recently
from
c7144cd to
3defd50
Compare
Gocnak
approved these changes
Jan 6, 2024
tsa96
force-pushed
the
refactor/constant-xp-systems
branch
from
3defd50 to
f656ac8
Compare
This isn't Prettier, it's just that since all the XP systems stuff moved to a separate class literally all is needed for the backend is an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, stores the XP system variables as hardcoded values in Typescript, moves over to a dedicated library that both front and backend can use, and removes the database table and admin endpoints used to store and modify the values.
On top of #867 and #869, those need reviewing first.