Map review endpoints #905
Merged
Map review endpoints #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
added
the
For: Backend
|
Will get CI passing after frontend side of this is finished. |
We had Axios in both regular and dev deps lol. Nest uses it at runtime, so it's a regular dependency.
tsa96
force-pushed
the
feat/map-review-endpoints
branch
7 times, most recently
from
784bd18 to
04fc334
Compare
Okay, we'll almost certainly never do this, but a map could MAYBE have 1000 review images. Plus this S3 service is just an implementation of the FileStoreService interface, good to not need to think about S3-specifics outside of this file.
Using this in backend code a bit, we actually have dependences that use it, but good to make explicitly
tsa96
force-pushed
the
feat/map-review-endpoints
branch
from
04fc334 to
301102d
Compare
GordiNoki
reviewed
Feb 20, 2024
…e module Sorry, some messy imports in here, add a bit of code for including comments that'll make sense after later commits in this PR, couldn't split up easily.
This shouldn't actually affect code at all since Prisma generates everything with LCC, just ugly
tsa96
force-pushed
the
feat/map-review-endpoints
branch
from
301102d to
b5762b0
Compare
GordiNoki
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the remaining backend map review stuff.
Also adds some image validation improvements.
Closes #804
Closes #806
Closes #904
Closes #900