⭐️ os cloud resource for azure #5305
Conversation
afiune
force-pushed
the
afiune/part3/azure/cloud-instance-metadata
branch
from
3d554d0 to
06318e7
Compare
afiune
force-pushed
the
afiune/part3/azure/cloud-instance-metadata
branch
from
06318e7 to
3d39678
Compare
Part 3 of #5284 This PR enables the new os resource `cloud` in Azure VMs. Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/part3/azure/cloud-instance-metadata
branch
from
3d39678 to
bac882e
Compare
| @@ -787,6 +787,9 @@ func (print *Printer) Data(typ types.Type, data interface{}, codeID string, bund | |||
| return print.Secondary(data.(string)) | |||
|
|
|||
| case types.IP: | |||
| if data == nil { | |||
| return print.Secondary("null") | |||
| } | |||
There was a problem hiding this comment.
This is fixed separately here #5307
| metadataIdentityScriptWindows = `Invoke-RestMethod -TimeoutSec 5 -Headers @{"Metadata"="true"} -Method GET -URI http://169.254.169.254/metadata/instance?api-version=2021-02-01 -UseBasicParsing | ConvertTo-Json` | ||
|
|
||
| loadbalancerMetadataScriptUnix = "curl --retry 5 --retry-delay 1 --connect-timeout 1 --retry-max-time 5 --max-time 10 --noproxy '*' -H Metadata:true http://169.254.169.254/metadata/loadbalancer?api-version=2021-02-01" |
There was a problem hiding this comment.
can we use a newer api-version?
https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=windows#supported-api-versions
We are not using version 2023-11-15 since it is still being rolled out and it may not be available in some regions. Docs: https://learn.microsoft.com/en-us/azure/virtual-machines/instance-metadata-service?tabs=windows#supported-api-versions Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/part3/azure/cloud-instance-metadata
branch
from
0e49c08 to
8b43a91
Compare
| } | ||
|
|
||
| // AddOrUpdatePrivateIP adds or updates one or many Ipv4Addresses | ||
| func (m *InstanceMetadata) AddOrUpdatePrivateIP(ips ...Ipv4Address) { |
There was a problem hiding this comment.
whats the use case in which we get the same ip twice so it needs to be updated? i'd expect the metadata to give us the IP addresses just once
There was a problem hiding this comment.
After doing extensive research, I discovered that the public IP address may come from two different endpoints within the IMDS, either the instance/ metadata or the loadbalander/ one.
So we don't know where will it come from, but we check both places looking. The question is, what do we do if it is present in both places? I say we merge the information in the best possible way, which is this implementation, but I am open to suggestions.
Part 3 of #5284
This PR enables the new os resource
cloudin Azure VMs.How to test this change
osprovider (how? docs here)cnquerybinarycnquery shell)cloudresource, trycloud.providerandcloud.instance {*}