🐛 omit storing force flag in config
#5309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
force-pushed
the
afiune/viper/omit-fields-from-config
branch
from
710d923 to
7858522
Compare
afiune
force-pushed
the
afiune/viper/omit-fields-from-config
branch
from
7858522 to
d529e03
Compare
afiune
commented
Mar 11, 2025
| @@ -200,9 +200,6 @@ func register(token string, annotations map[string]string, timer int, splay int, | |||
| } | |||
|
|
|||
| log.Debug().Msg("store configuration") | |||
| // overwrite force, otherwise it will be stored | |||
| viper.Set("force", false) | |||
There was a problem hiding this comment.
This never worked. And it was trying to unset a config setting in a single place. Moved it to the storing of the config instead.
Additionally, we have a way to add more fields we want to omit from storing in the config. Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/viper/omit-fields-from-config
branch
from
d529e03 to
f803086
Compare
vjeffrey
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, we have a way to add more fields we want to omit from storing
in the config.