Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the token minting and allowance system by replacing the
MintAllowanceUpgradeablecontract with a newRateLimitsUpgradeablecontract. Additionally, it includes various updates to deployment scripts and contract configurations to align with the new rate limits approach.Key Changes:
Major Contract Updates:
Rate Limits Implementation:
MintAllowanceUpgradeablewithRateLimitsUpgradeableto manage minting and burning limits more dynamically (src/RateLimitsUpgradeable.sol).Tokencontract to useRateLimitsUpgradeableinstead ofMintAllowanceUpgradeable(src/Token.sol). [1] [2] [3]Contract Adjustments:
ControllerToken,EthereumControllerToken,GnosisControllerToken,PolygonControllerToken) to use_useMinterLimitsinstead of_useMintAllowancefor checking minting permissions. [1] [2] [3] [4]Deployment and Configuration Scripts:
Script Updates:
configureToken.s.solto useLIMIT_CAPinstead ofMAX_MINT_ALLOWANCEand added new logic for setting rate limits (script/configureToken.s.sol). [1] [2]deployAll.sh(script/deployAll.sh). [1] [2]LIMIT_CAPenvironment variable (script/configureToken.sh).Batch Mint Script:
setMaxMintAllowanceandsetMintAllowancecalls in thebatchMint.s.solscript, indicating a shift away from the old allowance system (script/batchMint.s.sol).These changes collectively enhance the flexibility and security of the token minting process by introducing rate limits and updating the deployment scripts to support the new system.