feat(compass-generative-ai): don't require Atlas login, use the unauthenticated NLQ endpoints COMPASS-9688 #7191
Conversation
| @@ -151,13 +150,6 @@ export const featureFlags: Required<{ | |||
| }, | |||
| }, | |||
|
|
|||
| enableUnauthenticatedGenAI: { | |||
There was a problem hiding this comment.
I can just remove this rather than set stage to released, right? Or was there some reason you can't do that? I can never remember.
There was a problem hiding this comment.
sounds fine to me, not sure how it works generally though
There was a problem hiding this comment.
We generally just set these to released, yes. Makes sure that we're not breaking anything that happens to set this flag and expect it to be recognized, and that it won't conflict with a future Compass option
There was a problem hiding this comment.
I changed it now, but does that mean we can never remove these?
lerouxb
force-pushed
the
use-unauthenticated-endpoints
branch
from
5f4645c to
e8b4554
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the feature flag for unauthenticated GenAI and updates the service to use unauthenticated endpoints by default, eliminating the requirement for Atlas login when using generative AI features.
- Removes the
enableUnauthenticatedGenAIfeature flag from the preferences model - Updates AI service endpoints to use unauthenticated paths (
unauth/ai/api/v1/) - Simplifies the
ensureAiFeatureAccessmethod to only handle opt-in prompts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/compass-preferences-model/src/feature-flags.ts | Removes the enableUnauthenticatedGenAI feature flag definition |
| packages/compass-generative-ai/src/atlas-ai-service.ts | Updates endpoints to unauthenticated paths and simplifies access flow |
| packages/compass-generative-ai/src/atlas-ai-service.spec.ts | Removes test setup for the deleted feature flag |
lerouxb
force-pushed
the
use-unauthenticated-endpoints
branch
from
e8b4554 to
969bca8
Compare
The PR is still making it through the dev -> qa -> staging -> prod deployment phases and at the time of writing it is only deployed to and enabled on dev and qa. So we can't merge and release this yet.
But in the meantime you can test it like:
or
You can find other values to test different stages here.
This is in preparation for #7150. Probably only for after #7164 ?