refactor: use inspect and update comment

mongodb-js · Feb 19, 2025 · 81b2194 · 81b2194
1 parent 1c528e9
commit 81b2194
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 16 deletions.
diff --git a/packages/cli-repl/src/mongosh-repl.spec.ts b/packages/cli-repl/src/mongosh-repl.spec.ts
@@ -10,7 +10,7 @@ import type { Duplex } from 'stream';
 import { PassThrough } from 'stream';
 import type { StubbedInstance } from 'ts-sinon';
 import { stubInterface } from 'ts-sinon';
-import { promisify } from 'util';
+import { inspect, promisify } from 'util';
 import {
   expect,
   fakeTTYProps,
@@ -547,13 +547,11 @@ describe('MongoshNodeRepl', function () {
               input.write('history()\n');
               await waitEval(bus);
               expect(output).includes(
-                formatOutput(
-                  {
-                    value: getAllHistoryItems()
-                      .slice(1, getAllHistoryItems().length)
-                      .reverse(),
-                  },
-                  { colors: true, maxArrayLength: Infinity }
+                inspect(
+                  getAllHistoryItems()
+                    .slice(1, getAllHistoryItems().length)
+                    .reverse(),
+                  { maxArrayLength: Infinity }
                 )
               );
             });

diff --git a/packages/cli-repl/src/mongosh-repl.ts b/packages/cli-repl/src/mongosh-repl.ts
@@ -403,14 +403,18 @@ class MongoshNodeRepl implements EvaluationListener {
         replHistory.slice(1).reverse();
 
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      formattedHistory[util.inspect.custom as any] = (() => {
-        return formatOutput(
-          {
-            // Providing a copy of the history avoids a circular reference.
-            value: formattedHistory.concat(),
-          },
-          { colors: true, maxArrayLength: Infinity }
-        );
+      formattedHistory[util.inspect.custom as any] = ((
+        depth: number | null,
+        options: util.InspectOptions,
+        inspect: typeof util.inspect
+      ) => {
+        // We pass a copy of the array without the util.inspect.custom set
+        // to prevent infinite recursion.
+        return inspect(formattedHistory.concat(), {
+          ...options,
+          depth,
+          maxArrayLength: Infinity,
+        });
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
       }) as any;
       return formattedHistory;