chore: Migrate rhel81-power8 to rhel8-power9 MONGOSH-1835 #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
force-pushed
the
ni/new-distros
branch
from
ade8db0 to
cd22a28
Compare
* main: chore: update auto-generated files (#2237) feat(shell-api): add shardedDataDistribution to sh.status() MONGOSH-1326 (#2214) chore: update auto-generated files (#2235) feat(tests): Add individual evergreen test results with XUnit (#2227) chore: update auto-generated files (#2234) chore: rename service-provider-server and `CliServiceProvider` (#2232) chore: update auto-generated files (#2233) chore(deps): Add node-gyp version control across different distros MONGOSH-1891 (#2230) chore: update auto-generated files (#2231) fix(shell-api): Align database and collection aggregate functions MONGOSH-1868 (#2229)
nirinchev
changed the title
* main: chore: Migrate rhel72-zseries to rhel7-zseries MONGOSH-1835 (#2238) chore: update auto-generated files (#2244) chore(deps): bump driver, bson to latest MONGOSH-1890 MONGOSH-1889 (#2243) chore: update auto-generated files (#2242) chore: update auto-generated files (#2241) chore(ci): Add a workflow to validate PR titles (#2240)
addaleax
reviewed
Nov 4, 2024
addaleax
approved these changes
Nov 5, 2024
| @@ -7,6 +7,16 @@ EVGDIR="$ROOT_DIR/.evergreen" | |||
| NVM_DIR="$EVGDIR/.nvm" | |||
| ORIGINAL_PATH="${PATH}" | |||
|
|
|||
| OS_ARCH="$(uname "-m")" | |||
| if [ "$OS_ARCH" = "ppc64le" ] || [ "$OS_ARCH" = "ppc64" ] ; then | |||
| echo "[INFO] Choosing v4 because OS_ARCH is $OS_ARCH" | |||
There was a problem hiding this comment.
Just a small note, in scripts that already have set -x set, echoing back debug information can be nice for formatting but doesn't usually provide other benefits, since bash will already echo back the values for OS_ARCH, PATH, etc. when they are being set
There was a problem hiding this comment.
Yeah, I guess there's a small benefit of making this easier to grep if you notice it in the parsley logs + that was the original code before it got removed in 315fefa, so figured might keep it like that. I don't have strong opinions though and happy to remove it to keep the script more concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second half of MONGOSH-1835 - it moves to building for ppc to the new rhel8-power9 hosts. We had to bump the mongodb toolchain to v4 for these hosts due to an issue compiling
stat.hwith the v3 toolchain. This is temporary and likely to go away once MONGOSH-864 is completed.