DRIVERS-3032 ensure uv is installed after venv activation #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #591 and #591.
Several issues appear to be related to the errors that motivated prior PRs:
venv
already exists, it may be activated without a call topip install uv
even ifuv
has not yet been installed into that venv.venv/bin
orvenv/Script
. It is possible for the binary to reside in a deeper subdirectory such as "site-packages", which in turn may also be within a Python-versioned subdirectory, such as "python-3.12" (given uv is designed to support multiple Python versions). Thepushd $1
after activating the virtual environment may additionally break$PATH
expectations (although I would expect/assume callingpip
orpython -m pip
within an activate environment should be resiliant to this...).Regardless, it seems sufficent to 1) ensure
uv
is checked and installed after activation (regardless whether the environment already existed or not, and 2) store and use the full path to the resulting binary (viawhich
) to account for changing working directories.