Optimize BSON & GC handling. #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code gets called repeatedly, so it’s worth optimizing. This also optimizes the field-names uniqueness check.
FGasper
force-pushed
the
felipe_optimize_bson
branch
from
05f1ea5 to
2868f19
Compare
Unmarshaling is slow due to reflection. This function gets called frequently enough to justify the optimization.
FGasper
force-pushed
the
felipe_optimize_bson
branch
3 times, most recently
from
66c7611 to
31a3273
Compare
FGasper
force-pushed
the
felipe_optimize_bson
branch
from
31a3273 to
899476f
Compare
tdq45gj
approved these changes
Oct 27, 2025
mbson/raw_value.go
Outdated
| strLen := len(typedIn) | ||
| buf := make([]byte, 5+strLen) | ||
|
|
||
| binary.LittleEndian.PutUint32(buf, 1+uint32(strLen)) |
There was a problem hiding this comment.
Am I understanding it correctly that it is safe because all BSON values are little-endian except timestamp and counter values?
There was a problem hiding this comment.
All BSON numbers are little-endian, yeah. http://bsonspec.org
| // if the target type doesn’t match the value. | ||
| // | ||
| // Augment bsonType if you find a type here that’s missing. | ||
| func CastRawValue[T bsonCastRecipient](in bson.RawValue) (T, error) { |
There was a problem hiding this comment.
This function and ToRawValue seems to be re-implementing driver's logic. I wonder if the driver has the same functions or do we have to implement these ourselves.
There was a problem hiding this comment.
Good call … I found AppendInt32/Int64/String and have replaced them in here.
This makes the document IDs easier to reason about and sets up further optimizations. It also adds a few “shortcut” utilities to marshal/unmarshal BSON without reflection.
This fixes a typo that caused more recheck batches than was intended. It’s merely a small performance fix; it does not impact correctness.
This minimizes GC overhead, especially from BSON marshaling.
FGasper
force-pushed
the
felipe_optimize_bson
branch
from
899476f to
5afa227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several commits that optimize various aspects of BSON handling & garbage-collection.
The commits will be preserved in the merge. Review should consider each individually.