Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK] Remove unsupported configuration 'spark.mongodb.read.readPreference.name' #234

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

rachel-mack
Copy link
Contributor

@rachel-mack rachel-mack commented Jan 31, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43812

Staging Links

No pages to preview

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for docs-spark-connector ready!

Name Link
🔨 Latest commit 922afb0
🔍 Latest deploy log https://app.netlify.com/sites/docs-spark-connector/deploys/679d2c4d7a0b4b00087e31a9
😎 Deploy Preview https://deploy-preview-234--docs-spark-connector.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -15,8 +15,7 @@ specify them individually instead:

spark.mongodb.read.connection.uri=mongodb://127.0.0.1/
spark.mongodb.read.database=myDB
spark.mongodb.read.collection=myCollection
spark.mongodb.read.readPreference.name=primaryPreferred
spark.mongodb.read.collection=myCollection
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rozza Can you confirm this is the only instance of readPreference setting that needs to be removed from the page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats all thats needed. Its just configurable via the uri

@rachel-mack rachel-mack requested a review from rozza January 31, 2025 20:14
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachel-mack rachel-mack merged commit 856d992 into mongodb:master Feb 3, 2025
6 checks passed
@rachel-mack rachel-mack deleted the DOCSP-43812 branch February 3, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants