Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark Connector] Installation Instructions Are Missing Dependencies #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rachel-mack
Copy link
Contributor

@rachel-mack rachel-mack commented Feb 5, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41571

Staging Links

All tabs on the getting started page: https://deploy-preview-242--docs-spark-connector.netlify.app/getting-started/

  • java/api.rst
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Feb 5, 2025

    Deploy Preview for docs-spark-connector ready!

    Name Link
    🔨 Latest commit eec16d7
    🔍 Latest deploy log https://app.netlify.com/sites/docs-spark-connector/deploys/67a396edc2c4ec00086cc839
    😎 Deploy Preview https://deploy-preview-242--docs-spark-connector.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Comment on lines +46 to +56
    .. note::

    If you use the {+connector-short+} without the Java Driver, you must
    install the following libraries:

    - :java-docs:`BSON </apidocs/bson/index.html>`

    - :java-docs:`Core </apidocs/mongodb-driver-core/index.html>`

    - :java-docs:`Java Driver </apidocs/mongodb-driver-sync/index.html>`

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Tech reviewer question:
    Can you confirm that these are the equivalent packages for working with Scala and Python?

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is not needed / doesn't make sense - if they are using the maven coordinates as above it will pull in all the jars.

    If the user wants to supply --jars flag to spark-submit they can download an uber jar containing all the mongodb dependencies eg:

    mongo-spark-connector_2.12-10.4.1-all.jar
    

    Which is available on maven central to download.

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @rozza I'm trying to address this issue: https://jira.mongodb.org/browse/DOCSP-41571

    Do you think that they were having a problem specific to their own installation, or is there a step they were missing that we should make a note of in the documentation?

    Comment on lines +46 to +56
    .. note::

    If you use the {+connector-short+} without the Java Driver, you must
    install the following libraries:

    - :java-docs:`BSON </apidocs/bson/index.html>`

    - :java-docs:`Core </apidocs/mongodb-driver-core/index.html>`

    - :java-docs:`Java Driver </apidocs/mongodb-driver-sync/index.html>`

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is not needed / doesn't make sense - if they are using the maven coordinates as above it will pull in all the jars.

    If the user wants to supply --jars flag to spark-submit they can download an uber jar containing all the mongodb dependencies eg:

    mongo-spark-connector_2.12-10.4.1-all.jar
    

    Which is available on maven central to download.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants