-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spark Connector] Installation Instructions Are Missing Dependencies #242
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-spark-connector ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.. note:: | ||
|
||
If you use the {+connector-short+} without the Java Driver, you must | ||
install the following libraries: | ||
|
||
- :java-docs:`BSON </apidocs/bson/index.html>` | ||
|
||
- :java-docs:`Core </apidocs/mongodb-driver-core/index.html>` | ||
|
||
- :java-docs:`Java Driver </apidocs/mongodb-driver-sync/index.html>` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tech reviewer question:
Can you confirm that these are the equivalent packages for working with Scala and Python?
- Scala: top level package
- Python:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed / doesn't make sense - if they are using the maven coordinates as above it will pull in all the jars.
If the user wants to supply --jars
flag to spark-submit
they can download an uber jar containing all the mongodb dependencies eg:
mongo-spark-connector_2.12-10.4.1-all.jar
Which is available on maven central to download.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rozza I'm trying to address this issue: https://jira.mongodb.org/browse/DOCSP-41571
Do you think that they were having a problem specific to their own installation, or is there a step they were missing that we should make a note of in the documentation?
.. note:: | ||
|
||
If you use the {+connector-short+} without the Java Driver, you must | ||
install the following libraries: | ||
|
||
- :java-docs:`BSON </apidocs/bson/index.html>` | ||
|
||
- :java-docs:`Core </apidocs/mongodb-driver-core/index.html>` | ||
|
||
- :java-docs:`Java Driver </apidocs/mongodb-driver-sync/index.html>` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed / doesn't make sense - if they are using the maven coordinates as above it will pull in all the jars.
If the user wants to supply --jars
flag to spark-submit
they can download an uber jar containing all the mongodb dependencies eg:
mongo-spark-connector_2.12-10.4.1-all.jar
Which is available on maven central to download.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41571
Staging Links
All tabs on the getting started page: https://deploy-preview-242--docs-spark-connector.netlify.app/getting-started/
Self-Review Checklist