LG-5740 fix(LoadingIndicator) fixes spinner type references #3315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSonOfThomp
requested review from
adamrasheed,
Copilot and
tsck
and removed request for
a team
🦋 Changeset detectedLatest commit: 778f126 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes TypeScript type resolution issues for the loading-indicator package by correcting the casing in type definition paths within package.json exports. The paths now properly reference the PascalCase component directories (Spinner and PageLoader) instead of kebab-case, aligning with the actual build output structure.
Key Changes:
- Updated type definition paths to use correct PascalCase directory names
- Applied fix to both current TypeScript and legacy TypeScript 4.9 type paths
- Added changeset documentation for the patch release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/loading-indicator/package.json | Corrected type definition paths from kebab-case to PascalCase for spinner and page-loader exports |
| .changeset/loading-spinner-types.md | Added changeset documentation describing the TypeScript type resolution fix |
TheSonOfThomp
commented
Nov 14, 2025
Comment on lines
+22
to
+23
| "types": "./dist/types/Spinner/index.d.ts", | ||
| "types@<=5.0": "./dist/types/ts4.9/Spinner/index.d.ts", |
Collaborator
Author
There was a problem hiding this comment.
Our TS builds don't change the case of subdirectories
Contributor
|
Size Change: +1.39 kB (+0.08%) Total Size: 1.79 MB
ℹ️ View Unchanged
|
Contributor
|
Coverage after merging LG-5740-loading-spinner-types into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
adamrasheed
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
'@leafygreen-ui/loading-indicator': patch
Fixes types reference file in
package.json. Importing{ Spinner } from "@leafygreen-ui/loading-indicator/spinner"should no longer result in TS errors