LG-5635 fix unexpected @emotion imports in umd bundle of icons #3319
+56
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e2fd584 The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nima-taheri-mongodb
changed the title
Contributor
|
Size Change: +82 B (0%) Total Size: 1.79 MB
ℹ️ View Unchanged
|
Contributor
|
Coverage after merging cloudp-335379-fail-on-race-cond-on-icons into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
nima-taheri-mongodb
requested review from
Copilot,
stephl3 and
tsck
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in the icon package build process that was causing unexpected @emotion imports in UMD bundles. The core issue was that asynchronous buildPackage calls weren't being awaited, allowing subsequent build steps to run before bundling completed.
Key changes:
- Made
buildPackagefunction properly async/await instead of using promise chaining - Added await to
buildPackagecall in icon build script - Extended validation to check index.js for @emotion imports
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/build/src/rollup/build-package.ts | Converted promise chaining to async/await pattern to fix race condition |
| packages/icon/scripts/build/build.ts | Added await to buildPackage call to ensure build completes before validation |
| packages/icon/scripts/postbuild/index.ts | Removed skip logic for index.js to validate all files for @emotion imports |
| .changeset/great-birds-dress.md | Added changeset documenting the validation improvement |
Comment on lines
+27
to
+29
| export async function buildPackage({ | ||
| verbose, | ||
| }: BuildPackageOptions): Promise<void> { |
There was a problem hiding this comment.
The function JSDoc comment should be updated to reflect that this is now an async function that returns a Promise.
Collaborator
Author
There was a problem hiding this comment.
I think it's obvious from the signature.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-5635
📝 Description
This PR fixes unexpected @emotion imports in the UMD bundle of icons by correcting promise handling in the build process where buildPackage calls weren't being awaited, which could cause race conditions.
🧪 Testing
index.jsfor@emotionimports.act -j build -W ./.github/workflows/pr.yml --no-cache-server, I can confirm that after this change the race condition does not happen anymore.