[LG-5748] chore: Add Text and Border Color Variants #3321
+49
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c481f33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 87 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +1.81 kB (+0.1%) Total Size: 1.79 MB
ℹ️ View Unchanged
|
Contributor
|
Coverage after merging ar/LG-5748-color-tokens into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
adamrasheed
requested review from
Copilot,
shaneeza and
tsck
and removed request for
a team
Copilot finished reviewing on behalf of
adamrasheed
November 19, 2025 16:31
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the tokens package by adding new color variants and updating existing ones to better support the design system's needs. The changes provide more granular control over success states and tertiary UI elements.
Key changes:
- Added
Tertiaryborder color variant for both light and dark modes - Added
SuccessandSuccessLinktext color variants for both light and dark modes - Updated
SuccessandErrorborder color values to use lighter/darker shades for better visual hierarchy - Enhanced Storybook table readability by capitalizing variant type labels
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/tokens/src/color/color.types.ts | Added new variant enum values: Tertiary and SuccessLink |
| packages/tokens/src/color/lightModeColors.ts | Added Tertiary border colors, Success and SuccessLink text colors, and updated existing Success and Error color shades |
| packages/tokens/src/color/darkModeColors.ts | Added Tertiary border colors, Success and SuccessLink text colors, and updated existing Success and Error color shades |
| packages/tokens/src/Tokens.stories.tsx | Added CSS text-transform capitalization to improve variant label readability in Storybook |
| .changeset/moody-clouds-lead.md | Documented changes as a minor version bump with description of new variants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR adds new color token variants to support additional design system needs. The changes include:
tertiaryvariant for border colors (both light and dark modes)successvariant for text colors (both light and dark modes)successLinkvariant for text colors (both light and dark modes)successanderrorborder color values to use more appropriate shadesThese token additions provide more granular control over color variants across the design system, particularly for success states and tertiary UI elements.
🎟️ Jira ticket: LG-5748
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
tertiary,success,successLink) are displayed correctly in both light and dark modessuccessanderrorvariants render with the updated color valuessuccessandsuccessLinkvariants display appropriately across all interaction states