[LG-5532] feat(time-input): Segment state #3386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents with context integration
…tate handling in TimeInputInputs component
…segment rules and default values
… support 12/24 hour formats
…cale dependency and enhancing formatting logic
… format output with and without seconds
…meInputDisplayContext
…kMode and size, and add console log for debugging in TimeInputInputs
…omponent, covering rendering, value updates, and keyboard interactions
…omponent, covering rendering, value updates, and keyboard interactions
…12HourFormat prop, replacing TimeSegments with TimeSegment for improved clarity and consistency
…mponents with UTC conversion and logging for better time handling
…comparison logic in useSelectUnit hook
…logic for improved clarity
…alidation and date handling logic, including new utility functions for explicit segment checks
…n TimeInputInputs, removing unnecessary console logs and enhancing segment checks
…ime change checks for improved clarity and accuracy
… segment validation and date handling, enhancing utility functions for better clarity and performance
…d 24 hour formats, improving clarity on explicit value checks and segment validation
…across components, enhancing clarity and organization
…ate and segment updates, enhancing clarity in handling locale and timezone changes
…fygreen-ui into LG-5532/segments-display-values-state
…ting setSegment logic and cleaning up imports
…eparating date and segment change effects for improved clarity and functionality
…SegmentsAndSelectUnit for better clarity on date update logic
…es in useTimeSegmentsAndSelectUnit
… format handling in TimeInputInputs
… up imports in shouldSetValue
…ment handling and improving type safety
…TimeSegmentValidator for clarity and update its usage in isEverySegmentValueExplicit
…eExplicit tests for clarity and consistency
…ce getNewUTCDateFromSegments logic for better clarity
…and adjust related logic in TimeInputInputs and getFormattedDateTimeParts
…t handling and update getNewUTCDateFromSegments to utilize it
…ec for improved readability and consistency
…proving comments and consistency in date conversions
… by renaming timeZone variable for clarity
…rity across various utility tests
…and isSameUTCMonth.spec for better clarity and consistency
… across components
…imeSegmentAndSelectUnit.spec for improved clarity and consistency
… improve test descriptions for clarity
Base automatically changed from
LG-5532/segments-state-utils
to
shaneeza/segment-logic-integration
December 31, 2025 15:40
Contributor
|
Coverage after merging LG-5532/segments-display-values-state into shaneeza/segment-logic-integration will be
Coverage Report for Changed Files
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
+55
to
+59
| /** | ||
| * This useEffect is to check if the date has changed. | ||
| * If the date is different then we update the segments and call onUpdate. | ||
| */ | ||
| useEffect(() => { |
Collaborator
There was a problem hiding this comment.
all 3 of these effects have the same dependencies and have a lot of duplicatice code. Do we need 3 separate effects?
Comment on lines
+85
to
+88
| selectUnit: findUnitOptionByDayPeriod( | ||
| dayPeriod as DayPeriod, | ||
| unitOptions, | ||
| ), |
Collaborator
There was a problem hiding this comment.
we're calling this twice. should abstract to a separate var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
This PR implements state management for time input segments and the AM/PM select unit. The changes introduce
useTimeSegmentsAndSelectUnit(open to improving this name) hook to manage time segment state, select unit state, and coordinate updates between them while handling timezone and locale changes.This PR is the fourth PR in a chain of PRs
🧪 How to test changes