LG-5835: Rm dupe aria-* attributes in FormField #3417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruugey
requested review from
stephl3 and
tsck
and removed request for
a team
🦋 Changeset detectedLatest commit: cc23535 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes duplicate aria-* attributes in the FormField component by explicitly extracting them from props before spreading the rest object. This ensures aria-label, aria-labelledby, aria-invalid, and readOnly are not passed twice to child components.
Key Changes
- Extracted aria-label, aria-labelledby, aria-invalid, and readOnly from props destructuring
- Explicitly passed these attributes to formFieldInputContainerProps instead of via spread
- Added a changeset for @leafygreen-ui/tokens (appears to be in wrong PR)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/form-field/src/FormField/FormField.tsx | Extracted aria attributes and readOnly from props to prevent duplication when spreading rest |
| .changeset/calm-icons-shine.md | Added changeset for tokens package color updates |
.changeset/calm-icons-shine.md
Outdated
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| '@leafygreen-ui/tokens': patch | |||
There was a problem hiding this comment.
The changeset references '@leafygreen-ui/tokens' but this PR modifies '@leafygreen-ui/form-field'. The package name should be '@leafygreen-ui/form-field' to match the changed component.
Suggested change
| '@leafygreen-ui/tokens': patch | |
| '@leafygreen-ui/form-field': patch |
.changeset/calm-icons-shine.md
Outdated
Comment on lines
2
to
7
| '@leafygreen-ui/tokens': patch | ||
| --- | ||
|
|
||
| Updated color tokens: | ||
| - Adds border info, onInfo, warning, and onWarning tokens | ||
| - Adds text info, onInfo, warning, and onWarning tokens No newline at end of file |
There was a problem hiding this comment.
The changeset description mentions color token updates, but this PR removes duplicate aria-* attributes in FormField. The description should explain the actual changes: 'Fixes duplicate aria-* attributes (aria-label, aria-labelledby, aria-invalid) and readOnly prop being passed to child components in FormField.'
Suggested change
| '@leafygreen-ui/tokens': patch | |
| --- | |
| Updated color tokens: | |
| - Adds border info, onInfo, warning, and onWarning tokens | |
| - Adds text info, onInfo, warning, and onWarning tokens | |
| '@leafygreen-ui/form-field': patch | |
| --- | |
| Fixes duplicate aria-* attributes (aria-label, aria-labelledby, aria-invalid) and readOnly prop being passed to child components in FormField. |
Contributor
|
Size Change: +97 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
bruugey
force-pushed
the
brooke/form-field
branch
from
f3853b4 to
54c562e
Compare
Contributor
|
Coverage after merging brooke/form-field into main will be
Coverage Report for Changed Files
|
tsck
approved these changes
Dec 23, 2025
| '@leafygreen-ui/form-field': patch | ||
| --- | ||
|
|
||
| Removes duplicate `aria-*` attributes |
Collaborator
There was a problem hiding this comment.
Nit: also removes duplicate readonly attribute
shaneeza
reviewed
Dec 23, 2025
| 'aria-label': ariaLabelProp, | ||
| 'aria-labelledby': ariaLabelledbyProp, | ||
| 'aria-invalid': ariaInvalidProp, | ||
| readOnly, |
Collaborator
There was a problem hiding this comment.
I think we should match everything thats returned with input props:
Collaborator
There was a problem hiding this comment.
can we also add test specs for this fix?
stephl3
reviewed
Dec 23, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@leafygreen-ui/form-field': patch | |||
Collaborator
There was a problem hiding this comment.
I believe if this is a patch bump, it won't propagate to downstream dependencies unless they are explicitly listed here
| 'aria-label': ariaLabelProp, | ||
| 'aria-labelledby': ariaLabelledbyProp, | ||
| 'aria-invalid': ariaInvalidProp, | ||
| readOnly, |
Collaborator
There was a problem hiding this comment.
can we also add test specs for this fix?
| @@ -0,0 +1,5 @@ | |||
| --- | |||
Collaborator
There was a problem hiding this comment.
When checking the FormField storybook example, I see this change has addressed the initial issue, but it looks like there is a separate issue with duplicate usages of data-lgid and data-testid on different nodes. Can we batch those fixes with this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-5835
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes