restore C++ driver tests #2057
Open
restore C++ driver tests #2057
+165
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Sorry, thought I approved this but apparently not. LGTM with a minor comment.
Aside: I realized that this is a suboptimal testing setup, since we're just duplicating a lot of work where we build the C driver for multiple different C++ library versions (or none, as in one case), when it would be simpler to do all the test versions within a single EVG task and reuse the same build between them. I'll create a Jira ticket for this.
| @@ -38,7 +38,7 @@ | |||
| "Valid options for the SASL configuration parameter" | |||
| TLSOption = Literal["OpenSSL", "off"] | |||
| "Options for the TLS backend configuration parameter (AKA 'ENABLE_SSL')" | |||
| CxxVersion = Literal["none"] # TODO: Once CXX-3103 is released, add latest C++ release tag. | |||
| CxxVersion = Literal["r4.1.0", "none"] | |||
There was a problem hiding this comment.
Is 4.1.0 the only version we want to test at the moment? Do we care to test master?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1957 to restore C++ driver tests that were removed due to backwards breaking changes in C driver 2.0. The C++ driver r4.1.0 migrated to C driver 2.0, and now successfully builds.
Verified with this patch build: https://spruce.mongodb.com/version/68713f991a0d3a0007c0f055