CSHARP-5786: Add Decimal128 ctor overload for byte/short, for compatibility with net10 #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility with net10
BorisDog
requested review from
ajcvickers and
sanych-sun
and removed request for
ajcvickers
BorisDog
added
the
improvement
Copilot finished reviewing on behalf of
BorisDog
November 19, 2025 19:06
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit constructor overloads for byte and sbyte types to the Decimal128 struct to ensure compatibility with .NET 10, where implicit type conversion behavior may have changed.
- Adds
Decimal128(sbyte)constructor with proper negative value and edge case handling - Adds
Decimal128(byte)constructor for unsigned byte values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sanych-sun
pushed a commit
to sanych-sun/mongo-csharp-driver
that referenced
this pull request
Nov 19, 2025
…bility with net10 (mongodb#1819) (cherry picked from commit 1ef7fcc)
sanych-sun
added a commit
that referenced
this pull request
Nov 19, 2025
…bility with net10 (#1819) (#1820) (cherry picked from commit 1ef7fcc) Co-authored-by: BorisDog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.