CXX-3265 Update release instructions to use Amazon ECR instead of Artifactory #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eramongodb
changed the title
kevinAlbs
approved these changes
Jul 17, 2025
|
|
||
| RUN apk update && apk upgrade && apk add --no-cache openssl3 libstdc++ libc6-compat | ||
|
|
||
| COPY --from=builder /opt/mongocxx /usr/local | ||
|
|
||
| RUN true |
| "alpine3.19": "", | ||
| "bookworm": "\nRUN ldconfig\n", | ||
| "noble": "\nRUN ldconfig\n", | ||
| "alpine3.19": "\nRUN true", |
There was a problem hiding this comment.
Suggested change
| "alpine3.19": "\nRUN true", | |
| "alpine3.19": "", |
Remove unnecessary RUN true? I expect these changes were for newline consistency. Since a newline is later appended, I expect this can be empty.
There was a problem hiding this comment.
Annoyingly, if the expansion is empty (prior value of ""), the Dockerfile for alpine3.19 ends up with a trailing newline:
COPY --from=builder /opt/mongocxx /usr/local
+ (empty line)
(EOF newline)I could not find a way to coerce Jinja2 to avoid expanding {{ post_install_commands }} without an extra newline given a value of "" or None. For typical Jinja2 expansions, one would use % (e.g. {% var %}), but that doesn't seem to apply to {{ var }} expansions... 😕
.evergreen/scripts/sbom.sh
Outdated
Comment on lines
6
to
7
| : "${ARTIFACTORY_USER:?}" | ||
| : "${ARTIFACTORY_PASSWORD:?}" |
There was a problem hiding this comment.
No longer used:
Suggested change
| : "${ARTIFACTORY_USER:?}" | |
| : "${ARTIFACTORY_PASSWORD:?}" |
Comment on lines
74
to
75
| 'ARTIFACTORY_PASSWORD', | ||
| 'ARTIFACTORY_USER', |
There was a problem hiding this comment.
No longer used:
Suggested change
| 'ARTIFACTORY_PASSWORD', | |
| 'ARTIFACTORY_USER', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3265. Applies changes similar to those in mongodb/mongo-c-driver#2058.
extras/dockerare updated to support setting aDEFAULT_SEARCH_REGISTRYenvironment variable (pass tomake) which is forwarded as a Dockerdefault_search_registryargument, similar todefault_search_registryfor the Earthfile in CDRIVER-5971 Use Amazon ECR to obtain OCI images in EVG mongo-c-driver#2058. (Note: Earthfile syntax slightly differs from Dockerfile syntax.)The
generate.pyscript and related files has been drive-by improved for better consistency (e.g. trailing newlines) and with inline script metadata to supportuv run.