Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop ignoring id parameter #1622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop ignoring id parameter #1622

wants to merge 1 commit into from

Conversation

katcharov
Copy link
Contributor

@katcharov katcharov requested review from a team and vbabanin and removed request for a team February 5, 2025 14:27
@rozza
Copy link
Member

rozza commented Feb 6, 2025

Recommend adding a regression test here: GridFSPublisherSpecification

@jyemin jyemin requested review from jyemin and removed request for vbabanin February 10, 2025 13:44
jyemin
jyemin approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM without a test, but please open a ticket to investigate the seemingly total lack of testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katcharov @rozza @jyemin