Skip to content

sunset Astrolabe #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

sunset Astrolabe #1769

wants to merge 3 commits into from

Conversation

NathanQingyangXu
Copy link
Contributor

@NathanQingyangXu NathanQingyangXu marked this pull request as ready for review July 18, 2025 20:26
@NathanQingyangXu NathanQingyangXu requested a review from a team as a code owner July 18, 2025 20:26
@NathanQingyangXu NathanQingyangXu requested review from nhachicha and removed request for a team July 18, 2025 20:26
@NathanQingyangXu
Copy link
Contributor Author

I could delete the driver-workload-executor module, but then the following two checks would fail:

  • license/snyk
  • security/snyk

Could we delete the module without issue?

nhachicha
nhachicha reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@nhachicha nhachicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to update the submodule to sync the tests format as described in https://jira.mongodb.org/browse/JAVA-5798

@NathanQingyangXu
Copy link
Contributor Author

https://jira.mongodb.org/browse/JAVA-5798

@rozza , we have stopped cloning local unified testing cases but grabbed by fetching from upstream at run time, correct?

@jyemin
Copy link
Collaborator

jyemin commented Jul 22, 2025

I could delete the driver-workload-executor module, but then the following two checks would fail:

Why would they fail exactly?

@NathanQingyangXu
Copy link
Contributor Author

I could delete the driver-workload-executor module, but then the following two checks would fail:

Why would they fail exactly?

That is a mystery to me as well. We should delete driver-workload-executor module, right?

@rozza
Copy link
Member

rozza commented Jul 23, 2025

@rozza , we have stopped cloning local unified testing cases but grabbed by fetching from upstream at run time, correct?
Correct - I've just merged the latest dependabot commit - so we're up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhachicha nhachicha nhachicha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NathanQingyangXu @jyemin @rozza @nhachicha