-
Notifications
You must be signed in to change notification settings - Fork 103
[TEST] Bump Go to 1.25 #2708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[TEST] Bump Go to 1.25 #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jose.vazquez <[email protected]>
Signed-off-by: jose.vazquez <[email protected]>
8d5bac2
to
ec995c5
Compare
Signed-off-by: jose.vazquez <[email protected]>
ec995c5
to
0f095cf
Compare
This reverts commit f955392.
This reverts commit cefe84e.
Signed-off-by: jose.vazquez <[email protected]>
9bffec4
to
b4a764d
Compare
@roothorp I am not convinced it is useful to keep this draft open. If Nix fixes the deps issue for us, many of the changes here might not be needed. WDYT? |
too old, only useful for the findings summary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt to bump to Go 1.25, check what issues remain
Findings:
✅ Nix takes sometime to take Go major versions, but we can use the unstable channel to get them earlier.
✅ The
golangci-lint
tool just got updated to the new major Go version, so it can be updated from unstable and be fixed.🟠 The licenses check was failing, I had to remove the
GOTOOLCHAIN=local
setting to fix it. Consider go-licence-detector by Elastic as an alternative? -> CLOUDP-346331🟠 Unit tests failed with linker errors. In my Mac, they are due to a linker change in Go 1.25 that breaks the way to check mac certificates. On the CI it got fixed by removing the last bit of the go version in the go.mod line:
go 1.25
-> CLOUDP-346332✅ Mockery was also giving problems, version 2.53.3 complained that is was compiled with 1.24 and not working for 1.25. To fix I had to drop it from devbox and install version 2.53.5, compiled with 1.25 explicitly in the makefile.
🟠 Kubernetes main is already at Go 1.25 But last release 1.34.1 was still at 1.24.
Mac linker issue:
Proof of Work
Basic CI should pass
Checklist