Skip to content

CLOUDP-341448: openapi2crd unit-test and improvements #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2025
Merged

CLOUDP-341448: openapi2crd unit-test and improvements #2741

merged 6 commits into from
Oct 13, 2025

Conversation

@helderjs
Copy link
Collaborator

Summary

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

s-urbaniak
s-urbaniak reviewed Sep 29, 2025
View reviewed changes
tools/openapi2crd/pkg/plugins/atlas_sdk_version.go
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
Copy link
Collaborator

@s-urbaniak s-urbaniak Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we remove the license?

s-urbaniak
s-urbaniak reviewed Sep 29, 2025
View reviewed changes
tools/openapi2crd/pkg/generator/validate_test.go
@@ -0,0 +1,101 @@
package generator
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing apache licenses in all new files.

@helderjs helderjs marked this pull request as ready for review September 30, 2025 13:14
@helderjs helderjs requested a review from a team as a code owner September 30, 2025 13:14
josvazg
josvazg reviewed Oct 1, 2025
View reviewed changes
josvazg
josvazg reviewed Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow-up: This is huge, I would advise to split into smaller PRs for next iterations.

For instance, this could have been split into a still big but single focused test coverage PR, with just the bare minimum fixes to pass the tests. And another PR for other refactors, probably smaller and simpler to follow.

@josvazg
Copy link
Collaborator

josvazg commented Oct 1, 2025

comment: We probably want to wire a CI for this so we can see the tests passing.
I would do it in a small separate PR to merge before this one.

A single workflow such as the one for CRD2Go can do the job. We only need to run unit tests after all.

@helderjs
Copy link
Collaborator Author

helderjs commented Oct 9, 2025

comment: We probably want to wire a CI for this so we can see the tests passing. I would do it in a small separate PR to merge before this one.

A single workflow such as the one for CRD2Go can do the job. We only need to run unit tests after all.

I plan to do it in a follow-up PR. I'll create a ticket for it.
I'll past tests result from now below:

~/IdeaProjects/MongoDB/mongodb-atlas-kubernetes git:[CLOUDP-341448-openapi2crd-tests]
go test ./...
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/api      0.008s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1   6.947s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/authmode  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/common    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/project   [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/provider  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/api/v1/status    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/cmd      [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/cmd/post-install [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/cmp     0.004s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/collection      0.003s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/compare [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/compat  0.003s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller      0.030s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlas        0.019s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasbackupcompliancepolicy  0.159s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlascustomrole      0.099s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasdatabaseuser    0.178s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasdatafederation  0.097s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasdeployment      0.204s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasfederatedauth   0.110s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasipaccesslist    0.125s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasnetworkcontainer        0.103s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasnetworkpeering  0.119s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasorgsettings     0.116s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasprivateendpoint 0.108s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasproject 0.495s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlassearchindexconfig       0.182s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasstream  0.375s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlasthirdpartyintegrations  0.234s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/customresource       0.179s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/reconciler   0.183s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/secretservice        0.203s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/statushandler        0.154s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/validate     0.024s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/watch        0.017s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/workflow     0.240s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/deprecation     [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/dryrun  0.403s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/featureflags    0.014s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/httputil        0.014s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/indexer 0.427s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/kube    0.047s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/mocks/atlas     [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/mocks/translation       [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/nextapi/v1      [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/operator        0.232s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/pointer 0.011s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/run     0.111s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/set     0.009s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/stringutil      0.012s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/timeutil        0.003s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation     [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/atlasorgsettings    0.018s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/audit       0.023s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/customroles [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/datafederation      0.816s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/dbuser      0.022s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/deployment  0.080s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/encryptionatrest    0.021s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/ipaccesslist        0.032s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/maintenancewindow   0.022s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/networkcontainer    0.119s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/networkpeering      0.126s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/paging      0.003s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/privateendpoint     0.052s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/project     0.076s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/searchindex 0.082s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/searchindex/fake    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/tag [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/teams       0.086s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/thirdpartyintegration       0.080s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/version 0.021s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/controller/state     0.328s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/finalizer    0.239s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/predicate    0.068s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/ratelimit    0.086s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/result       0.078s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/state        0.015s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/scripts  [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/e2e 0.029s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/e2e2        0.019s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helm        0.084s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/access       [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/atlas        [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/cel  0.026s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/cel/fake     [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/cloud/aws    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/cloud/azure  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/cloud/google [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/cmd  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/conditions   [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/control      [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/decoder      [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/actions  [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/actions/cloud    0.013s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/actions/cloudaccess      [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/actions/deploy   [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/actions/kube     [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/actrc    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/api/atlas        [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/api/aws  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/api/azure        [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/api/gcp  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/appclient        [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/cli      [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/cli/helm [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/cli/kustomize    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/cli/oc   [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/cli/opm  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/cli/podman       [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/config   [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/data     [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/debug    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/fixtest  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/k8s      [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/model    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e/utils    [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e2/kube    [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e2/operator        0.024s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/e2e2/yml     0.028s
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/events       [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/maintenance  [no test files]
?       github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/resources    [no test files]
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/helper/retry        0.130s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/int 0.015s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/test/int/clusterwide     0.015s
ok      github.com/mongodb/mongodb-atlas-kubernetes/v2/tools/compute-test-labels        0.004s

@josvazg
Copy link
Collaborator

josvazg commented Oct 13, 2025

Any blockers to merge this?

@helderjs helderjs merged commit 5ba63c8 into main Oct 13, 2025
1 check passed
@helderjs helderjs deleted the CLOUDP-341448-openapi2crd-tests branch October 13, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@josvazg josvazg josvazg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@helderjs @josvazg @s-urbaniak