external mongod #308
external mongod #308
Conversation
MCK 1.2.1 Release NotesOther Changes
|
… anandsyncs/external-mongod
| type ExternalMongodTLS struct { | ||
| Enabled bool `json:"enabled"` | ||
| // +optional | ||
| CASecretRef *userv1.SecretKeyRef `json:"caSecretRef,omitempty"` |
There was a problem hiding this comment.
CA doesn't need to be a secret. See TLSConfig struct used in our CRDs
| } | ||
|
|
||
| func (r *externalSearchResource) IsSecurityTLSConfigEnabled() bool { | ||
| if r.spec.TLS != nil { |
There was a problem hiding this comment.
nit: we can simplify as return r.spec.TLS != nil && r.spec.TLS.Enabled
| @@ -31,27 +35,78 @@ const ( | |||
| // | |||
| // TODO check if we could use already existing interface (DbCommon, MongoDBStatefulSetOwner, etc.) | |||
| type SearchSourceDBResource interface { | |||
| Name() string | |||
There was a problem hiding this comment.
Could you please check if this removal won't clash with enterprise support in #309?
| sample_movies_helper.assert_search_query(retry_timeout=60) | ||
|
|
||
|
|
||
| def get_connection_string(mdbc: MongoDBCommunity, user_name: str, user_password: str) -> str: |
There was a problem hiding this comment.
we should probably make this an utility function as we have few copies of it already
| { | ||
| "mongotHost": mongot_host, | ||
| "searchIndexManagementHostAndPort": mongot_host, | ||
| "skipAuthenticationToSearchIndexManagementServer": False, |
There was a problem hiding this comment.
why no searchTLSMode in here? Is it defaulting to true?
|
|
||
| @mark.e2e_search_external_tls | ||
| def test_validate_tls_connections(mdbc: MongoDBCommunity, mdbs: MongoDBSearch, namespace: str, issuer_ca_filepath: str): | ||
| with pymongo.MongoClient( |
There was a problem hiding this comment.
can we use ReplicaSetTester.assert_connectivity for checking connection to mongodb? It guess it's doing exactly what we do here.
| @@ -834,7 +837,8 @@ func getMongodConfigModification(mdb mdbv1.MongoDBCommunity) automationconfig.Mo | |||
| // getMongodConfigModification will merge the additional configuration in the CRD | |||
| // into the configuration set up by the operator. | |||
| func getMongodConfigSearchModification(search *searchv1.MongoDBSearch) automationconfig.Modification { | |||
| if search == nil { | |||
| // Condition for skipping add parameter if it is external mongod | |||
There was a problem hiding this comment.
nit: unnecessary comment as it's just explain this simple code
There was a problem hiding this comment.
ah yes, I simplified the logic but didn't remove the comment, thanks for pointing out.
Summary
Proof of Work
Checklist
skip-changeloglabel if not needed