chore: Add autogen type override support for sets and lists #3775
Conversation
|
|
||
| func configBasic(orgID, name, description string, roles []string, secretExpiresAfterHours int) string { | ||
| rolesStr := fmt.Sprintf(`%q`, strings.Join(roles, `", "`)) | ||
| rolesStr := `"` + strings.Join(roles, `", "`) + `"` |
There was a problem hiding this comment.
Fixing non-matching escapes
There was a problem hiding this comment.
was this also incorrect in non-api resource test, to fix it there too?
There was a problem hiding this comment.
No handwritten resource for this one yet. I did check that we are using this in other tests.
manupedrozo
force-pushed
the
CLOUDP-349935-autogen-basic-type-override
branch
from
cc755b3 to
752cdb6
Compare
manupedrozo
changed the title
| func applyTypeOverride(override *config.Override, attr *Attribute) { | ||
| switch *override.Type { | ||
| case config.Set: | ||
| if attr.List != nil { |
There was a problem hiding this comment.
should we throw an error if trying to override to set something that is not a list? same for list
There was a problem hiding this comment.
Currently we ignore it and print a warning, similar to applyTimeoutConfig() below.
+1 on moving to errors - ideally in another PR since we need a refactor.
There was a problem hiding this comment.
+1 for errors in this case, warnings may be easy to miss in automation
| overrides: | ||
| list_string: | ||
| type: set | ||
| description: "List overridden to set" |
There was a problem hiding this comment.
Just indicating that we are overriding the type. Could have gone for a comment as well.
There was a problem hiding this comment.
i'd probably go for a comment if we're not using the field
| - Test Singleton Resource | ||
| "/api/atlas/v2/groups/{groupId}/testResourceWithCollections": | ||
| delete: | ||
| description: DELETE API description |
There was a problem hiding this comment.
similarly as in another comment, what is description used for here?
There was a problem hiding this comment.
We set them for all operations, kept for consistency.
3 participants
Description
Allow overriding an attribute's type in the autogen config.
Currently supporting
settolistandlisttosetoverrides.Overriding the
rolesattribute in theorg_service_account_apiresource fromlisttoset. This is necessary since the API spec is missing theuniqueItems: trueconfiguration (see CLOUDP-348768).Enabling the
TestAccOrgServiceAccountAPI_rolesOrderingacceptance test.Link to any related issue(s): CLOUDP-349935
Type of change:
Required Checklist:
Further comments