Skip to content

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Oct 14, 2025

Description

Enable resource policy tests with SA credentials.

Link to any related issue(s): CLOUDP-350334

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli marked this pull request as ready for review October 14, 2025 21:35
@lantoli lantoli requested a review from a team as a code owner October 14, 2025 21:35
@Copilot Copilot AI review requested due to automatic review settings October 14, 2025 21:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables resource policy tests to use service account (SA) credentials as an alternative to API key authentication. The change adds support for client ID and secret authentication alongside existing public/private key authentication for resource policy testing.

  • Adds new service account credential inputs to the GitHub Actions workflow
  • Updates the test runner to conditionally use either API keys or service account credentials based on the use_sa parameter
  • Maintains backward compatibility with existing API key authentication

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/acceptance-tests.yml Adds service account client ID and secret inputs for resource policy tests
.github/workflows/acceptance-tests-runner.yml Updates workflow to conditionally use SA credentials and adds new required inputs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lantoli lantoli merged commit 8194d8a into CLOUDP-334161-service-accounts-dev Oct 15, 2025
138 checks passed
@lantoli lantoli deleted the CLOUDP-350334_rp_sa branch October 15, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants