-
Notifications
You must be signed in to change notification settings - Fork 644
Add SkSL image filter support (ToImageFilter / SKRuntimeImageFilterBuilder) #3778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattleibow
wants to merge
35
commits into
main
Choose a base branch
from
mattleibow/dev-runtime-shader-image-filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 33 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
bc58f68
Add SKImageFilter.CreateRuntimeShader API
mattleibow 664f4dc
Merge remote-tracking branch 'origin/main' into mattleibow/dev-runtim…
mattleibow 531d597
Refactor RuntimeShader API to ToImageFilter/BuildImageFilter pattern
mattleibow 9cbf0ee
Polish API: reorder params, add simpler overloads, move tests
mattleibow aa61329
Final API design: 5+10 overloads, multi-child, unsharp mask sample
mattleibow b8c1f8d
Add SKRuntimeImageFilterBuilder, use marshalled strings
mattleibow 648bd56
Merge remote-tracking branch 'origin/main' into mattleibow/dev-runtim…
mattleibow dc034f3
Fix samples: SampleCategories -> SampleManager after merge
mattleibow 8815273
Make Title, Description, DateAdded abstract on SampleBase
mattleibow 089fc64
Narrow 'new sample' window from 10 days to 3 days
mattleibow f4211fe
Add SKRuntimeEffectImageFilterInputs for typed input binding
mattleibow 88acd54
Show Inputs pattern explicitly in RuntimeShader sample
mattleibow 4890d5c
Remove unnecessary Inputs assignment in single-child sample
mattleibow cc85ad9
Revert SampleBase/SampleManager changes, keep DateOnly? nullable
mattleibow 1748c34
Restore DateOnly? on all existing samples
mattleibow b299ae8
Use Dictionary for Inputs, only pass explicitly set entries
mattleibow 61049a8
Make Names/Count/Contains reflect set inputs, not effect children
mattleibow fc7d917
Use rented arrays in ToImageFilter to avoid allocations
mattleibow 4b6d6e0
Add internal AsData/AsArray for future allocation work (#3859)
mattleibow a930d0c
Add tests for Inputs Names/Count/Contains, Reset, invalid name, null …
mattleibow 37da64d
Fix object leaks in tests - dispose all SKShader and SKImageFilter in…
mattleibow 9baa36c
Use RentHandlesArray for input handles instead of stackalloc
mattleibow 8c106c4
Eliminate children.ToArray() copies in image filter path
mattleibow afd467d
Remove raw array overloads from ToImageFilter
mattleibow fe66083
Simplify to two clean private methods: Single and Multi
mattleibow d8492c3
Pass SKRuntimeEffectImageFilterInputs directly to ToImageFilterMulti
mattleibow 90fbbfb
Simplify C API: drop children param, use STArray
mattleibow c76edb7
Restore children param in C API, pass through from C#
mattleibow ad13038
Fix maxSampleRadius on single-child path, cache builders in samples
mattleibow 923a130
Address review: fix exception param, Names allocation, GC safety, tes…
mattleibow 7a8363f
Restrict Inputs to shader-type children, fix vignette allocation
mattleibow 537817d
Fix stackalloc scope error in vignette sample
mattleibow bc918de
Merge remote-tracking branch 'origin/main' into mattleibow/dev-runtim…
mattleibow 1703ab0
Merge remote-tracking branch 'origin/main' into mattleibow/dev-runtim…
mattleibow 954660e
Add ApiTags to runtime shader image filter gallery samples
mattleibow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule skia
updated
3 files
| +2 −0 | include/c/sk_runtimeeffect.h | |
| +1 −0 | src/c/sk_imagefilter.cpp | |
| +33 −0 | src/c/sk_runtimeeffect.cpp |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.