Mobile 4802 #4405
Open
Mobile 4802 #4405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonso-salces
force-pushed
the
MOBILE-4802
branch
from
b512a1a to
12d4750
Compare
crazyserver
requested changes
Jul 15, 2025
| @@ -80,7 +80,7 @@ export class CoreDynamicComponent<ComponentClass> implements OnChanges, DoCheck, | |||
| setTimeout(() => this.createComponent()); | |||
| } | |||
|
|
|||
| protected promisedInstance = new CorePromisedValue<any>(); // eslint-disable-line @typescript-eslint/no-explicit-any | |||
| promisedInstance = new CorePromisedValue<any>(); // eslint-disable-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
You don't need this change, you can wait the instance to be ready() (awaiting) and the use the get instance()
| @@ -34,7 +34,7 @@ import { CoreSharedModule } from '@/core/shared.module'; | |||
| }) | |||
| export class CoreBlockComponent implements OnChanges, OnDestroy { | |||
|
|
|||
| @ViewChild(CoreDynamicComponent) dynamicComponent?: CoreDynamicComponent<ICoreBlockComponent>; | |||
| dynamicComponent: Signal<CoreDynamicComponent<ICoreBlockComponent> | undefined> = viewChild(CoreDynamicComponent); | |||
There was a problem hiding this comment.
It's preferably to infer the type from the viewChild(...) can you move the type there?
| const dynamicComponent = this.block()?.dynamicComponent(); | ||
|
|
||
| if (dynamicComponent) { | ||
| this.myOverviewBlock = await dynamicComponent.promisedInstance; |
There was a problem hiding this comment.
Check the other commit about the promisedInstance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.