-
Notifications
You must be signed in to change notification settings - Fork 23
Embedded Questions: make it work for M5.0 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We added two new optional params: courseshortname/questionbankidnumber
53e00ce
to
2fc16c9
Compare
@vuvanhieu143 Fantastic job! Thank you very much for your fixes. I have tested your developments at TU Wien test instances with Moodle 5.0 see [1] All works fine now. |
just noting this PR seems to fail the following upstrem unit tests:
|
Thanks for raising the issue, @danmarsden. I’ll fix it now. It’s strange that it also caused another failure in a core plugin. |
cool thanks for doing that! - I was hoping to get one of our team to dig into it further but great you've been able to sort it - I've just run that through the unit tests again on our side and all passing and handed over to the team to test the interface and will drop any further feedback here in case it's useful. |
I see that codechecker has changed some rules, which is now breaking the build. I think we should probably fix that in a separate pull request (soon). Let us try to get this one merged without extra complications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of excellent work here. Let me start by saying that, becuase there are also some details which don't see quite right yet.
The main problems to solve are with the form fields used. Remember, you cannot trust anything coming from the client-side, even if it was one of your forms, unless you validate it server-side. So, that needs fixing.
And, related to this, some of the internal APIs are unnecessarily tangled.
Apart from that, I think it is minor things.
Good tests, which hopefully help with fixing things safely.
And, thank you for cleaning up some of the bits of code that are no longer needed in modern Moodle versions. (But, also thank you for not cleaning up too many things in this change which is already very big.)
8fdc119
to
2e8bd61
Compare
Hi @timhunt ,
Could you please help to review those code changes. I try to separate it into several commits :
After we merged this, the failed automation test in this PR will passed:
moodleou/moodle-tiny_embedquestion#8