-
Notifications
You must be signed in to change notification settings - Fork 121
refactor: introduce Source trait for random generator #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Missing type constraint on `Source` implementationCategory Deprecated function still used in documentation exampleCategory let r = @random.Rand::new(@random.chacha8()) Reasoning Missing documentation for trait methodsCategory pub(open) trait Source {
///| Generates the next 64-bit unsigned random integer
next(Self) -> UInt64
} Reasoning |
Pull Request Test Coverage Report for Build 6209Details
💛 - Coveralls |
adfbb29
to
88a992d
Compare
88a992d
to
f89b61d
Compare
@@ -24,7 +27,7 @@ impl Rand { | |||
float(Self) -> Float | |||
int(Self, limit~ : Int = ..) -> Int | |||
int64(Self, limit~ : Int64 = ..) -> Int64 | |||
new(seed~ : Bytes = ..) -> Self //deprecated | |||
new(&Source) -> Self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a default value
Closes #1589