-
Notifications
You must be signed in to change notification settings - Fork 122
Add set operations to @immut/hash{map, set}
and @internal/sparse_array
Summary
#2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Asterless
wants to merge
24
commits into
moonbitlang:main
Choose a base branch
from
Asterless:feature/20250522_HAMT
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a9b3888
feat: add four new functions to HAMT and their tests
Asterless 09b6a99
fix(union_with): fix union_with for HAMT,now it can handle branch
Asterless 1b84483
feat(sparse_array): add intersection and difference methods
Asterless 0cdca5b
fix(HAMT): fix union_with, intersection, intersection_with and differ…
Asterless 44c0a79
feat(hashset): add intersection and difference methods to hashset
Asterless f80c9f2
commit other files
Asterless 7f2524c
feat: add four new functions to HAMT and their tests
Asterless fc71f34
fix(union_with): fix union_with for HAMT,now it can handle branch
Asterless 5adb5ce
feat(sparse_array): add intersection and difference methods
Asterless 8d06b82
fix(HAMT): fix union_with, intersection, intersection_with and differ…
Asterless eb6ef82
feat(hashset): add intersection and difference methods to hashset
Asterless 61ca5f0
Merge branch 'feature/20250522_HAMT' of github.com:Asterless/core int…
Asterless a0d7669
style: change the position of some function declarations
Asterless 29c51a5
fix: fix formatting of the code
Asterless 4b46d45
Merge pull request #1 from Asterless/feature/20250522_HAMT
Asterless 256557a
Merge branch 'main' of github.com:Asterless/core
Asterless dab49f5
feat: Update the function declarations of hash tables and sparse arrays
Asterless 779268b
Merge branch 'main' into feature/20250522_HAMT
Lampese 3f120f1
Merge branch 'main' into feature/20250522_HAMT
Asterless 34bce14
Merge branch 'main' into feature/20250522_HAMT
Asterless 3b99be9
Merge branch 'main' into feature/20250522_HAMT
Asterless 139cda1
Merge branch 'main' into feature/20250522_HAMT
Lampese 0f648d5
Merge branch 'main' into feature/20250522_HAMT
Asterless d72a3c0
Merge branch 'main' into feature/20250522_HAMT
Lampese File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just make it a method
pub fn[K : Eq + Hash, V] T::union_with(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!😊 It's just that I don't quite understand why this was done. When I added this method, I observed that other methods didn't make such modifications