add proper attribute to view types

[Yu-zh]

• Added #builtin.valtype mainly for documentation purpose
• Deprecated @string.StringView in favor of @string.View

[peter-jerry-ye-code-review]

Inconsistent deprecation annotations between files

Category
Maintainability
Code Snippet
file: string/view.mbt
#deprecated("use @string.View instead")

file: builtin/arrayview.mbt
#deprecated("use @array.View instead")
Recommendation
Ensure deprecation messages follow the same format across all files, preferably with information about when it will be removed and migration steps if needed
Reasoning
Consistent deprecation messages help developers understand when and how to migrate their code. Consider adding version numbers or timeline for removal.

Missing documentation for new #builtin.valtype annotation

Category
Maintainability
Code Snippet
#builtin.valtype
struct ArrayView[T] {
buf : UninitializedArray[T]
start : Int
}
Recommendation
Add documentation comments explaining the purpose and implications of the #builtin.valtype annotation
Reasoning
Since this annotation is mainly for documentation purposes (as stated in PR message), its meaning and impact should be clearly documented for other developers

Function signature update needed in other files using StringView

Category
Correctness
Code Snippet
fn check_and_consume_base(
view : @string.StringView,
base : Int
) -> (Int, @string.StringView, Bool)!StrConvError
Recommendation
Search and update all other files that might still be using @string.StringView to use @string.View instead
Reasoning
To maintain consistency and prevent future issues, all occurrences of the deprecated type should be updated to use the new type

[coveralls]

Pull Request Test Coverage Report for Build 6909

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 92.454%

---

Totals
Change from base Build 6906:	0.0%
Covered Lines:	8687
Relevant Lines:	9396

---

💛 - Coveralls