Skip to content

Conversation

peter-jerry-ye
Copy link
Collaborator

@peter-jerry-ye peter-jerry-ye commented Sep 12, 2025

Notice : this will cause the output be filled with the output from panic test. We may need to filter them @lynzrand @bobzhang

@lynzrand
Copy link
Collaborator

lynzrand commented Sep 12, 2025

I can mitigate this by capturing test outputs by default, only outputting when the relevant tests fail (we can't put tests on the panic message itself, unless we accept false negatives).

Changes needed:

  • Capture stdout and associate each segment with each test result
  • Hide the output by default
  • Print the output on test failure, or if a flag like --no-capture is set.

I am currently unsure if this is the desired change.

@lynzrand
Copy link
Collaborator

I am creating a new issue to track this change in moon.

@peter-jerry-ye peter-jerry-ye changed the title feat: enable abort for non-wasm backend feat: enable abort for native backend Sep 17, 2025
@peter-jerry-ye
Copy link
Collaborator Author

Since the capturing is still WIP, this PR will only enable the output of abort for native backend

@peter-jerry-ye peter-jerry-ye marked this pull request as ready for review September 17, 2025 03:16
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1233

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.651%

Totals Coverage Status
Change from base Build 1231: 0.0%
Covered Lines: 9295
Relevant Lines: 10368

💛 - Coveralls

@peter-jerry-ye peter-jerry-ye enabled auto-merge (rebase) September 18, 2025 02:16
@peter-jerry-ye peter-jerry-ye merged commit 974c684 into main Sep 18, 2025
15 of 16 checks passed
@peter-jerry-ye peter-jerry-ye deleted the zihang/enable-abort branch September 18, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants