fix(regex): reject empty unicode brace escape - #4102
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the regex parser’s escape handling so that an empty Unicode brace escape (\u{}) is rejected as an invalid escape sequence, rather than being partially parsed as literal characters (notably inside character classes).
Changes:
- Reject stray
\uprefixes in both character-class parsing (class_atom) and general term parsing (term) by raisingHINT_INVALID_ESCAPEwhen they don’t match a valid\uXXXXor\u{X...}form. - Add a regression test ensuring
[\u{}]fails withParserError(..., hint="Invalid escape sequence").
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| string/internal/regex_parser/parser.mbt | Adds explicit rejection of invalid/partial \u escape sequences to prevent \u{} from being mis-parsed. |
| string/internal/regex_parser/parser_test.mbt | Adds a test case covering the newly rejected empty Unicode brace escape inside a character class. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Coverage Report for CI Build 6165Coverage decreased (-0.004%) to 90.682%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix wrong behavior of regex parser, make it reject empty unicode brace escape.