fix(shell): allow trusted Moon test output pipelines - #841
Draft
bobzhang wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
headoutput limitermoon test -uandmoon test --updatetee, and writer-after-pipe forms sandboxedmoon test cfront/build -u 2>&1 | head -40Why
sandbox-execapplies to the completesh -cprocess. The previous classifier rejected every pipeline before considering its individual stages, so piping a trusted snapshot update throughheaddemoted the whole command to the source-read-only sandbox. Moon then failed to promote snapshots withOperation not permitted.The new classification composes stage effects: the Moon invocation carries trusted-write capability and
headis a read-only consumer. A pipeline is still rejected if a stage is untrusted or if a writer appears after a pipe.Impact
Agents can run bounded test commands such as:
Snapshot promotion can write the expected
.mbtsource while unsafe pipeline shapes retain the existing sandbox behavior.Validation
moon check agent_tool/shell --target nativemoon test agent_tool/shell --target native— 132/132 passedmoon info && moon fmt— no interface changesjust checkjust buildjust test— 3432/3433 passed; one unrelated desktop session-read test hit its 1s timeout, and its isolated rerun passed 1/1